Fix #214: Prevent scope change for function calls when optimising switches #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
A procedure call can use variables from current scope as call parameters.
When the switch is optimised as a procedure call, a return action in caller's scope is created, and wrong variables may be accessed.
Prevent this by considering procedure calls like any complex expression, and allow the switch to be rewritten.
It's not needed for random switches as variables are always accessed inSELF
scope for them.Don't optimise procedure calls in random switches.
And while I was updating a regression test, I decided to include string test for #205.